test(common): add unit test suites for LRUCache and MinHeap - #1012
test(common): add unit test suites for LRUCache and MinHeap#1012kranthik10 wants to merge 1 commit into
Conversation
|
Nice contribution. Both suites are well-structured and cover the meaningful edge cases: constructor validation ( This is exactly the kind of test-only PR that's low-risk to port by hand - no production code touched, assertions are specific rather than snapshot-style, and the tests exercise real behavior rather than re-asserting implementation details. A couple of minor things a maintainer might want before/while porting:
Overall: good scope, correct layer (tests only, no production code changed), reasonable coverage. Worth porting. |
Adds complete test suites for LRUCache (used in LLM token caching) and MinHeap (priority queue data structure) with 100% test pass rate.